Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add dbt-core~=1.8.0a1 as convenience dep #1002

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

Problem

We need to preserve backwards compatibility for installing this package.

Solution

Include dbt-core as a dependency for installation, but do not depend on it within functional code.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 3, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@mikealfare mikealfare merged commit 377c65f into main Apr 3, 2024
31 checks passed
@mikealfare mikealfare deleted the dependencies/add-core branch April 3, 2024 19:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants