Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add tests for --empty flag #948

Merged
merged 4 commits into from
Dec 1, 2023
Merged

add tests for --empty flag #948

merged 4 commits into from
Dec 1, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Nov 19, 2023

resolves #949
docs dbt-labs/docs.getdbt.com/# N/A

Problem

dbt-labs/dbt-core#8971 introduced a new --empty flag that required implementation changes to the BaseRelation.

Solution

Add tests in dbt-bigquery to ensure expected behaviour of the new --empty flag when running with dbt-redshift.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Nov 19, 2023
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

dev-requirements.txt Outdated Show resolved Hide resolved
@MichelleArk MichelleArk marked this pull request as ready for review November 20, 2023 15:06
@MichelleArk MichelleArk requested a review from a team as a code owner November 20, 2023 15:06
@mikealfare mikealfare merged commit d0a60a7 into main Dec 1, 2023
17 checks passed
@mikealfare mikealfare deleted the support-empty branch December 1, 2023 22:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-1038] [Tests] Add tests for --empty flag
2 participants