Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

include streaming_table and fix materialized_view in databricks__get_table_types_sql() #862

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

w0ut0
Copy link

@w0ut0 w0ut0 commented Jan 5, 2024

solves #861
solves #881

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

databricks__get_table_types_sql() will now handle streaming_tables

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@dbeatty10 dbeatty10 added the bug Something isn't working label Apr 18, 2024
@Dynosphere
Copy link

This is the same file that has a bug with MATERIALIZED VIEW.
If you could roll in the change from MATERIALIZED VIEW -> MATERIALIZED_VIEW we can also close: #881

@w0ut0 w0ut0 changed the title include streaming_table in databricks__get_table_types_sql() include streaming_table and fix materialized_view in databricks__get_table_types_sql() Sep 28, 2024
@w0ut0
Copy link
Author

w0ut0 commented Sep 28, 2024

Hi @Dynosphere, I added your suggestion, thanks!
Is there something that still needs to be done in order to get this merged? I see it wasn't included in the 1.3.0 release.
Maybe @dbeatty10?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants