Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

examples broken by d3@6 #1769

Closed
3 tasks done
gordonwoodhull opened this issue Sep 16, 2020 · 3 comments
Closed
3 tasks done

examples broken by d3@6 #1769

gordonwoodhull opened this issue Sep 16, 2020 · 3 comments

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Sep 16, 2020

The following examples were broken in 4.1 by updating D3

  • click limit on histogram - d3.event
  • horizon chart - looks like bad code scaleOrdinal().domain(1,6); also uses d3.nest
  • range series - animated transitions are incredibly slow (not that there should be any in this example)
@parksj10
Copy link

I guess this came after the stackoverflow post :), definitely interested to see it still

@gordonwoodhull
Copy link
Contributor Author

Yes, after I commented I thought, gee better try that link, and it didn’t work. It’s a trivial issue and should be easy to fix.

Actually the horizon chart example is rather idiosyncratic: it does things differently from most normal charts. It would be nice to have a more normal external chart example, like one using D3FC.

gordonwoodhull added a commit that referenced this issue Sep 18, 2020
gordonwoodhull added a commit that referenced this issue Sep 18, 2020
for #1769

there may be an underlying bug, but the old behavior was unpleasant anyway
@gordonwoodhull
Copy link
Contributor Author

I fixed these examples in version 4.1.1.

(There are no changes to the core library, so I guess it didn't need a version bump, and I could just have updated the website.)

kum-deepak pushed a commit that referenced this issue Nov 2, 2020
kum-deepak pushed a commit that referenced this issue Nov 2, 2020
no d3.event anymore

(cherry picked from commit f1674a0)
kum-deepak pushed a commit that referenced this issue Nov 2, 2020
for #1769

there may be an underlying bug, but the old behavior was unpleasant anyway

(cherry picked from commit cf43692)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants