Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

2.x support - crossfilter.quicksort removed in crossfilter2@1.5.0 #1862

Open
kuzjka opened this issue Mar 12, 2022 · 0 comments
Open

2.x support - crossfilter.quicksort removed in crossfilter2@1.5.0 #1862

kuzjka opened this issue Mar 12, 2022 · 0 comments

Comments

@kuzjka
Copy link

kuzjka commented Mar 12, 2022

dc 2.x declares major version dependency of crossfilter2: ^1.4.6
However, crossfilter2 1.5 has a breaking change. quicksort function is not used anymore (see Release notes ), but the function was exported and used by dc

Following error occurs with dc 2.2.2 and crossfilter2 1.5.2:

Uncaught TypeError: e.quicksort is undefined
    ordering dc.js:1342
    capMixin dc.js:4473
    rowChart dc.js:8595
    ...

I'll prepare a PR for 2.x to limit crossfilter2 dependency to 1.4.x as a quickfix for your consideration.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant