Add ability to set max legend item count #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to set max item count in legend
|
Thanks @renoth and sorry for the slow response. This is a good idea and I only wonder if we need to add an ellipsis or something to indicate that items were removed. I take it you use this for a chart where the items are ordered from greatest to least, and you don't want to use .cap(), or it's not available for the chart you're using? |
|
Thanks @renoth! This is going into dc.js 2.0. I tried adding an ellipsis item and it looked dumb, so I'm not doing that. (Also I figured it would probably have to be a link to show the rest, and that's a bigger effort.) Added a couple of tests, checked for invalid numbers as you suggested, and also allowed zero (because why not). |
gordonwoodhull
added a commit
that referenced
this pull request
Jan 3, 2017
gordonwoodhull
added a commit
that referenced
this pull request
Jan 3, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this for a project so i implemented it and wanted to share with you guys.