Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

specified first two elements of d.key to pass to isFiltered() #1123

Closed
wants to merge 1 commit into from

Conversation

KatiRG
Copy link

@KatiRG KatiRG commented Apr 6, 2016

Needed when length of d.key > 2 (for example, it can contain a colour index) because dc.filters.RangedTwoDimensionalFilter returns false if value.length !== 2 (see line 954).

@gordonwoodhull
Copy link
Contributor

Thanks @KatiRG! Applied your change for 2.0 beta 28. We presently do not have any tests for extra values in the keys, and I'm not adding any now, but it would probably be smart in the future.

In general this won't work for charts that use the entire key, but the scatter plot explicitly looks only at key[0] and key[1], so this looks safe to me.

@gordonwoodhull
Copy link
Contributor

Rebased and merged in 2.0 beta 28

@KatiRG
Copy link
Author

KatiRG commented May 2, 2016

Great, glad to help!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants