jslint and jshint clean #1372
Merged
jslint and jshint clean #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I also pushed artifacts so now there is a built dc.js 3.0.0-alpha.1 and d3.js 4.13 in (technically we don't need these until release, but it's nice to have a baseline and people can try it out if they want.) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have excluded
src/d3v3-compat.jsfrom the checks - did not want to change external code. Also handled little differently unused functions warning inspec/coordinate-grid-chart-spec.jsThanks for your suggestion - now lint in run before commit.