Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

allow clearing of a single renderlet or all renderlets #779

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions spec/base-mixin-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,20 @@ describe("dc.baseMixin", function () {
expect(firstRenderlet).toHaveBeenCalled();
expect(secondRenderlet).toHaveBeenCalled();
});

it('should clear a renderlet when asked', function () {
chart.clearRenderlet(firstRenderlet);
chart.redraw();
expect(firstRenderlet).not.toHaveBeenCalled();
expect(secondRenderlet).toHaveBeenCalled();
});

it('should clear all renderlets when asked', function () {
chart.clearRenderlets();
chart.redraw();
expect(firstRenderlet).not.toHaveBeenCalled();
expect(secondRenderlet).not.toHaveBeenCalled();
});
});

describe('event listeners', function () {
Expand Down
19 changes: 19 additions & 0 deletions src/base-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,25 @@ dc.baseMixin = function (_chart) {
return _chart;
};

/**
#### .clearRenderlet(renderletFunction)
Removes a renderlet function you have previously added to the chart
**/
_chart.clearRenderlet = function (_) {
for (var i = 0; i < _renderlets.length; ++i) {
if (_renderlets[i] === _) { _renderlets.splice(i, 1); }
}
};

/**
#### .clearRenderlets()
Removes all renderlet functions from the chart
**/
_chart.clearRenderlets = function () {
_renderlets.length = 0;
return _chart;
};

function runAllRenderlets() {
for (var i = 0; i < _renderlets.length; ++i) {
_renderlets[i](_chart);
Expand Down