Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes filtering on render #900

Closed
wants to merge 1 commit into from
Closed

Fixes filtering on render #900

wants to merge 1 commit into from

Conversation

mtraynham
Copy link
Contributor

After a render, an ordinal coordinate grid doesn't retain its faded area. Simple fix.

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone May 24, 2015
@gordonwoodhull
Copy link
Contributor

Thanks. I think there are more than a few places where dc.js assumes nothing will be filtered on render.

@gordonwoodhull
Copy link
Contributor

Thanks @mtraynham, merged.

gordonwoodhull added a commit that referenced this pull request Jul 30, 2015
@gordonwoodhull
Merge #900
ebb50ed 
Conflicts:
	src/coordinate-grid-mixin.js
@mtraynham mtraynham deleted the fix_coordinate_grid_ordinal_filter_render branch August 7, 2015 01:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
non-breaking
Development

Successfully merging this pull request may close these issues.
2 participants
@mtraynham @gordonwoodhull