Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

web/examples: add table-onaggregated-data #929

Closed
wants to merge 1 commit into from

Conversation

yetanotherion
Copy link
Contributor

This commit shows how to create a table
on aggregated data. This currently works
even out of luck :), by setting a
dimension.group().reduce(...)
object instead of a dimension in the table.

More precisely, it works if the table's:

  • .group() is defined, and returns the same value for all elements
  • .order() is defined & defined to something else than the default value
    (which seems to be either d3.ascending or descending, a method that is
    undefined for .reduce()-d dimension groups is called else).

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone May 1, 2015
@gordonwoodhull
Copy link
Contributor

Thanks, this looks good. To clarify, this is for #927 and the idea is to also document that a data table can take a group instead of a dimension (and that it has a completely freakazoid idea of what a group is).

I'll fix the docs at the same time I merge this.

This commit show how to create a table
on aggregated data. This currently works
even out of luck :), by setting a
dimension.group().reduce(...)
object instead of a dimension in the table.

More precisely, it works if the table's:
-  .group() is defined, and returns the same value for all elements
-  .order() is defined & defined to something else than the default value
   (which seems to be either d3.ascending or descending, a method that is
    undefined for .reduce()-d dimension groups is called else).
@yetanotherion
Copy link
Contributor Author

Updated the PR to fix typo & useless modifications of index.html

@gordonwoodhull
Copy link
Contributor

Thanks @yetanotherion, merged for 2.0 beta 13

@yetanotherion
Copy link
Contributor Author

you're welcome :)

2015-07-30 9:59 GMT+02:00 Gordon Woodhull notifications@github.com:

Thanks @yetanotherion https://github.com/yetanotherion, merged for 2.0
beta 13


Reply to this email directly or view it on GitHub
#929 (comment).

Ion

gordonwoodhull added a commit that referenced this pull request Jul 30, 2015
for #929
artifacts and attribution
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants