Market_Value Attributes Update #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes dict is additionally filled with market values (current and highest)
dcaribou
requested changes
Sep 24, 2021
| @@ -73,6 +73,8 @@ def parse_details(self, response, base): | |||
| attributes['contract_expires'] = self.safe_strip(response.xpath("//span[text()='Contract expires:']/following::span[1]/text()").get()) | |||
| attributes['day_of_last_contract_extension'] = response.xpath("//span[text()='Date of last contract extension:']/following::span[1]/text()").get() | |||
| attributes['outfitter'] = response.xpath("//span[text()='Outfitter:']/following::span[1]/text()").get() | |||
| attributes['current_market_value'] = response.xpath("//div[@class='marktwertentwicklung']//div[@class='zeile-oben']//div[@class='right-td']//a/text()").get().strip() | |||
There was a problem hiding this comment.
This looks great @DonFloriano27!
Just one tiny detail: would you mind using the self.safe_strip method to do the stripping instead of calling .strip() on the string? This will make a little bit more robust and it wont' fail in case if the scraped value is a null.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes dict is additionally filled with market values (current and highest)