module: Add EBS extra volume support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow extra EBS volumes to be created for each AWS instance.
fatz
reviewed
Feb 6, 2019
| @@ -121,6 +121,7 @@ module "dcos-infrastructure" { | |||
| private_agents_os = "${var.private_agents_os}" | |||
| private_agents_root_volume_size = "${var.private_agents_root_volume_size}" | |||
| private_agents_root_volume_type = "${var.private_agents_root_volume_type}" | |||
| private_agents_extra_volumes = ["${var.private_agents_extra_volumes}"] | |||
There was a problem hiding this comment.
with this we need to have a minimum ref to the next version of instance
|
min version of infra needs to be raised as mentioned in dcos-terraform-terraform-aws-infrastructure#20 next patch num is safe to use |
This is because new variables are introduced.
|
@fatz PTAL again. I bump the dependency version |
fatz
approved these changes
Feb 6, 2019
|
have a question: How to use this? |
|
@Rohithzr you can take a look into the instance module https://github.com/dcos-terraform/terraform-aws-instance#example |
|
@fatz thanks, I have one question though, does this method also mounts those volumes to the instance? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow extra EBS volumes to be created for each AWS instance.