Skip to content

Fix tests failing when LANG="en_US.UTF-8" environment variable not set #42

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Fix tests failing when LANG="en_US.UTF-8" environment variable not set #42

merged 2 commits into from
Nov 6, 2021

Conversation

krzesii
Copy link
Contributor

@krzesii krzesii commented Nov 5, 2021

Hi @deanwampler,

Here's fix for tests failing when locale are different than en_US - issue #39. As an alternative in Intellij Idea it is possible to add -Duser.language=en_US JVM flag in Settings -> Build, Execution, Deployment -> sbt in VM parameters field.

Fix tested with following config:

  • sbt 1.55
  • AdoptOpenJDK 11
  • Ubuntu 21.04
  • LANG env variable set to pl_PL.UTF-8

Thank you for writing the book, I have really enjoyed learning with it so far.

@krzesii krzesii marked this pull request as ready for review November 5, 2021 16:23
@ddl-deanwampler
Copy link

Thanks for this! I'll review and merge this weekend.

@deanwampler deanwampler merged commit 2a07af4 into deanwampler:master Nov 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants