enable() invalidates created loggers that should be enabled

[turnerhayes]

For example, let's say I have the following:

const debug = require("debug");
const foobarDebug = debug("foo:bar");

debug.enable("foo:*");

console.log("debug.enabled('foo:bar')?", debug.enabled("foo:bar"));
console.log("foobarDebug enabled?", foobarDebug.enabled);

will output

debug.enabled('foo:bar')? true
foobarDebug enabled? false

If you create the debugger after calling enable() it works as expected. I understand that enable() overrides what was previously enabled, but I would expect that anything that passes the new filters would be enabled.

[Qix-]

Agreed, this needs to be fixed.

[mblarsen]

I tried adding this unit test and the issue seems to be resolved. But perhaps I misunderstood the issue.

	describe('issues', () => {
		it('#533: set enabled after creating instance', () => {
			const fooBar = debug('foo:bar');
			expect(fooBar.enabled).to.be.equal(false);
			debug.enable('foo:*');
			expect(debug.enabled('foo:bar')).to.be.equal(true);
			expect(fooBar.enabled).to.be.equal(true);
		});
	});

[Qix-]

You did. Try this:

debug.enable('foo:*');
debug('foo:bar').enabled // => true

debug.enable('bar:*');
debug('bar:foo').enabled // => true
debug('foo:bar').enabled // => false :(

[mblarsen]

Yes, that is the #425 issue.

In this issue, however, the namespace enable is called with a namespace string that matches an existing instance.

Same cause different problem perhaps.

[Qix-]

Closing in favor of #425. I'm moving the whole .enable()/.disable() renovations there.