Skip to content

Export getDate so can be overwritten #525

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Export getDate so can be overwritten #525

wants to merge 1 commit into from
+1 −0

Conversation

reggi
Copy link

@reggi reggi commented Nov 27, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 75.152% when pulling 99101f8 on reggi:patch-1 into 285dfe1 on visionmedia:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 75.152% when pulling 99101f8 on reggi:patch-1 into 285dfe1 on visionmedia:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 75.152% when pulling 99101f8 on reggi:patch-1 into 285dfe1 on visionmedia:master.

@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

I'm 👎 on this - we need a better, more standardized way to change the date format. See #582 for some of this.

Thoughts @TooTallNate and @thebigredgeek?

@Qix- Qix- added feature This proposes or provides a feature or enhancement needs-documentation This issue or change requires additional documentation labels Jun 20, 2018
@Qix- Qix- mentioned this pull request Jun 20, 2018
Open
@Qix- Qix- added the change-minor This proposes or provides a change that requires a minor release label Sep 11, 2018
@Qix-
Copy link
Member

Qix- commented Dec 13, 2018

Closing in favor of #582.

@Qix- Qix- closed this Dec 13, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change-minor This proposes or provides a change that requires a minor release feature This proposes or provides a feature or enhancement needs-documentation This issue or change requires additional documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reggi @coveralls @Qix-