Skip to content

Custom output formatting #645

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Custom output formatting #645

wants to merge 8 commits into from

Conversation

chagris
Copy link

@chagris chagris commented Dec 13, 2018

Closes #582.

This pull request is an attempt at implementing #582. As stated by my comment there, this code isn't yet complete and actually ready to be merged, and is waiting for edits and feebacks!

@coveralls
Copy link

coveralls commented Dec 13, 2018

Coverage Status

Coverage increased (+0.4%) to 87.179% when pulling 8fa6444 on chagris:format into 5fadf45 on visionmedia:master.

@Qix- Qix- added feature This proposes or provides a feature or enhancement change-major This proposes or provides a change that requires a major release labels Dec 13, 2018
@Qix- Qix- self-requested a review December 13, 2018 15:18
@chagris
Copy link
Author

chagris commented Dec 14, 2018

I added the "metaformatters" flag prefixes %J (JSON.stringify()), %c and %C (color and color + bold (node)) as I proposed here #582 (comment), however I'm not 100% on it (they could just as well stay special-case-flags), so it should be easy to revert

Also, I'm not sure what to do about node's formatters %o / %O coloring (based on DEBUG_COLORS and isatty()), and passing other inspectOpts

@Qix- Qix- changed the title Custom output formatting implementation proposal (#582) Custom output formatting Dec 19, 2018
@Qix-
Copy link
Member

Qix- commented Dec 19, 2018

Hey @chagris - sorry I haven't had time to review this or give much input. However I appreciate the work being done.

Admittedly it'll be a little longer before I'll be able to get to this; however, I've done two things here:

  1. I revised this PR's title a bit to be less 'prototype'-ey
  2. I added the magic keywords Closes #xxx. which Github will handle upon merging this PR.

@Qix- Qix- added this to the 5.x milestone Dec 19, 2018
@Qix- Qix- mentioned this pull request Dec 19, 2018
11 tasks
@RabiaSaid
Copy link

2.6.8

@RabiaSaid
Copy link

4.3.4

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
change-major This proposes or provides a change that requires a major release feature This proposes or provides a feature or enhancement
Development

Successfully merging this pull request may close these issues.

Customizing output format
4 participants