-
Notifications
You must be signed in to change notification settings - Fork 945
Improvement of memory management for #678 #699
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
…reated. Fix memory leak for a fixed number of categories. For dynamic categories method destroy is still required. debug-js#678
Thanks for this PR! I was thinking of submitting a similar one myself, as we just discovered that this memory leak was hitting us hard. I was thinking about using a Map instead of an object for the instances. Would that be a better choice? Map seems like the more suitable data structure for this usage and would simplify the code in |
I have no objection of using |
Avoiding recreating logger for the namespace which has been already created. Fix memory leak for a fixed number of categories. For dynamic categories method destroy is still required. #678