Add option to log to STDOUT #965
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerard Hickey <hickey@kinetic-compute.com>
hickey
force-pushed
the
choose_file_descriptor
branch
from
9481d46 to
27d567f
Compare
|
Anybody still working on this project? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change recognizes the
DEBUG_USE_STDOUTenvironmental variable to allow log messages to be directed toSTDOUTwhen the NodeJS version is being used. Please refer to #964 for the use case to support this change.I have added a test that I think will work for testing this functionality. Since my NodeJS knowledge is not that great I can not say for certain that it works as I expect it to. It is my hope that you will correct any problem with the test.
Closes #964