Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixed oledump.plugin_biff_error in plugin_biff.py #435

Closed
wants to merge 1 commit into from
Closed

Fixed oledump.plugin_biff_error in plugin_biff.py #435

wants to merge 1 commit into from

Conversation

S-MaN14th
Copy link

Fixed by converting the byte to a str before adding to strings.
Works with EXCEL macro 4.0

@S-MaN14th S-MaN14th closed this Apr 19, 2019
@S-MaN14th S-MaN14th reopened this Apr 19, 2019
@decalage2 decalage2 self-requested a review April 20, 2019 14:18
@decalage2 decalage2 added this to the oletools 0.54 milestone Apr 20, 2019
decalage2
decalage2 reviewed May 19, 2019
View reviewed changes
Copy link
Owner

@decalage2 decalage2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's a step in the right direction, but to support both python 2 and 3 I think I need to modify more things in the code. I'm working on a different, more global solution, so I'll close this PR. Thanks again for contributing.

@decalage2 decalage2 closed this May 19, 2019
@decalage2
Copy link
Owner

I fixed #428 in commit 8159c1b

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@decalage2 decalage2 decalage2 left review comments

Assignees
No one assigned
Labels
🐛 bug plugin_biff
Projects
None yet
Milestone
oletools 0.54
Development

Successfully merging this pull request may close these issues.
2 participants
@S-MaN14th @decalage2