Unittest fixes, reduce output #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adapting the test a while ago, Samir forgot that this one test tested with multiple args. That was unnecessary, anyway, so removed them.
Prevent unwanted FileNotFoundError caused by wrong test code shadow actual msodde output
Instead of calling main() in current interpreter, fork a new one using call_and_capture
This way, we get the output even in error case to simplify debugging
This is kind of a hack, hope this can be removed once other branch is merged (see code comment)
Closed
|
Thanks :-) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unittests have been issuing warnings for a while now, "just" wanted to fix these. Turns out, some were right, quite a few file handles did need closing, some tests needed adjustments. Also reduced the output that unittests produced, some problems were hidden in the long stream of irrelevant text output.