Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: change EditorToolbar position style #7198

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

camdenvaughan
Copy link
Contributor

Changed ToolbarContainer's position element to be absolute - #7197

Fixes #7197

Summary

I was following the docs and wanted to mount decap inside of a div on my page, this worked good on the landing page of decap but did not work once I was on an editing page. The editor toolbar had a fixed position to the top so it would come out of my div and cover the custom header that I had made.

Test plan

I ran the tests using npm, at first they failed since the editor toolbar did not match the snapshot but since changing the component was what was intended, I updated the snapshot and the tests passed. (there was a warning that was also present before my change)

Screenshots before my change (I have decap mounted inside of a div that only covers 90% width of the page and has a header and footer above and below)
Before Change (ToolbarContainer has a position of fixed)
Screenshot 2024-05-05 231725
AfterChange (ToolbarContainer has a position of absolute)
Screenshot 2024-05-05 231122

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)
bean

Changed ToolbarContainer's position element to be absolute - decaporg#7197
@camdenvaughan camdenvaughan requested a review from a team as a code owner May 6, 2024 03:24
@martinjagodic martinjagodic enabled auto-merge (squash) June 26, 2024 13:25
@martinjagodic martinjagodic disabled auto-merge June 26, 2024 14:02
@martinjagodic martinjagodic merged commit dc71d72 into decaporg:main Jun 26, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor Does not respect Custom Mount Element
2 participants