Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(backend): allow a custom API root for backend #7214

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

JbIPS
Copy link
Contributor

@JbIPS JbIPS commented May 23, 2024

In case of a self-hosted Gitlab, the API request to get the default branch always call gitlab.com.
This commit allow to pass a custom API root from the config to the API call.

Fixes #7168

In case of a self-hosted Gitlab, the API request to get the default
branch always call gitlab.com.
This commit allow to pass a custom API root from the config to the API
call.

Fix decaporg#7168
@JbIPS JbIPS requested a review from a team as a code owner May 23, 2024 09:32
@martinjagodic
Copy link
Member

@JbIPS could you add this new setting to docs also? the best way is to submit a PR here: https://github.com/decaporg/decap-website

@JbIPS
Copy link
Contributor Author

JbIPS commented Jul 2, 2024

Actually, the apiRoot setting is not new (https://decapcms.org/docs/backends-overview/), it was just not used for the calls on GitLab branches.

@dbtek
Copy link

dbtek commented Jul 3, 2024

Hi @JbIPS. Thanks for the effort.
I'd like to use decap with self hosted Gitlab and blocked by this issue also. Can we see the fix in a release any time soon?

@JbIPS
Copy link
Contributor Author

JbIPS commented Jul 3, 2024

Hi @dbtek! Did you add branch: master in your config? It is a valid workaround for now

@dbtek
Copy link

dbtek commented Jul 3, 2024

Hi @JbIPS. Yeah I found it by accident 😊. It seems working now. Thanks!

@martinjagodic martinjagodic enabled auto-merge (squash) August 2, 2024 07:27
@martinjagodic martinjagodic merged commit fae3e05 into decaporg:main Aug 2, 2024
9 checks passed
martinjagodic added a commit that referenced this pull request Aug 5, 2024
In case of a self-hosted Gitlab, the API request to get the default
branch always call gitlab.com.
This commit allow to pass a custom API root from the config to the API
call.

Fix #7168

Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend for self-hosted Gitlab still queries gitlab.com
3 participants