Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add loading and teleport logs #3436

Merged
merged 12 commits into from
Feb 27, 2025
Merged

Conversation

lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Feb 25, 2025

Pull Request Description

Add logs (always) when:

  • the player is teleporting
  • the loading status changes
  • a scene start being downloaded
  • a scene finishes downloading
  • a scene is started
  • a scene is disposed

This addresses half of the issue #3428

Test Instructions

Test Steps

  1. Go around by foot and teleport
  2. Check that everything you did was specifically logged

Code Review Reference

Please review our Code Review Standards before submitting.

@lorenzo-ranciaffi lorenzo-ranciaffi marked this pull request as ready for review February 25, 2025 16:05
@lorenzo-ranciaffi lorenzo-ranciaffi requested review from a team as code owners February 25, 2025 16:05
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✅ Backpack and wearables in world
  • ✅ Emotes in world and in backpack
  • ✅ Teleport with map/coordinates/Jump In
  • ✅Profile card
  • ✅ Camera
  • ✅Skybox
  • ✅Settings

Example of the implementation:

  1. <color=#BDB8AC>[ALWAYS]: Trying to teleport to (-102, -97). Attempt
    2 and 3. <color=#BDB8AC>[ALWAYS]: Current loading stage: Init
    <color=#BDB8AC>[ALWAYS]: Current loading stage: UnloadCacheChecking
    <color=#BDB8AC>[ALWAYS]: Current loading stage: PlayerTeleporting
  2. <color=#BDB8AC>[ALWAYS]: Current loading stage: Completed

@lorenzo-ranciaffi lorenzo-ranciaffi merged commit 3c1682a into dev Feb 27, 2025
6 checks passed
@lorenzo-ranciaffi lorenzo-ranciaffi deleted the feat/add-loading-logs branch February 27, 2025 15:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants