Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: anonId from app args #3442

Merged
merged 2 commits into from
Mar 3, 2025
Merged

feat: anonId from app args #3442

merged 2 commits into from
Mar 3, 2025

Conversation

NickKhalow
Copy link
Contributor

@NickKhalow NickKhalow commented Feb 26, 2025

Pull Request Description

What does this PR change?

  1. Added a propagation for anon_id from IAppArgs to RustSegmentAnalyticsService.
  2. Improved LaunchTraits. LaunchTraits is immutable with an explicit ctor in this version.

Test Instructions

Prerequisites

  • Get access to the segment admin panel

Test Steps

Windows

  1. Find your ID at C:\Users\{user_name}\AppData\Roaming\config.json (It should appear after you launched DCL launcher once)
  2. Launch game with command Decentraland.exe --launcher_anonymous_id YOUR_ID
  3. Validate that your id is displayed in segment's debugger from unity main source

MacOS

  1. Find your ID at ~/Library/Application\ Support/config.json (It should appear after you launched DCL launcher once)
  2. Launch game with command open Decentraland.app --args --launcher_anonymous_id YOUR_ID
  3. Validate that your id is displayed in segment's debugger from unity main source

Additional Testing Notes

  • Note any edge cases to verify - Unknown
  • Mention specific areas that need careful testing - Unknown
  • List known limitations or potential issues - If you launch the game from the launcher normally you won't get the right anon id because the launcher uses latest main version by default

Quality Checklist

  • [+] Changes have been tested locally
  • [+] Performance impact has been considered - No significant performance changes

Code Review Reference

Please review our Code Review Standards before submitting.

@NickKhalow NickKhalow self-assigned this Feb 26, 2025
@NickKhalow NickKhalow requested review from a team as code owners February 26, 2025 11:14
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✅ Backpack and wearables in world
  • ✅ Emotes in world and in backpack
  • ✅Teleport with map/coordinates/Jump In
  • ✅ Profile card
  • ✅ Camera
  • ✅ Skybox
  • ✅ Settings

Evidence of the PR's functionality:
image

@NickKhalow NickKhalow merged commit b3866a5 into dev Mar 3, 2025
7 checks passed
@NickKhalow NickKhalow deleted the feat/same-anon-id branch March 3, 2025 12:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants