Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
IAppArgs
toRustSegmentAnalyticsService
.LaunchTraits
. LaunchTraits is immutable with an explicit ctor in this version.Test Instructions
Prerequisites
Test Steps
Windows
C:\Users\{user_name}\AppData\Roaming\config.json
(It should appear after you launched DCL launcher once)Decentraland.exe --launcher_anonymous_id YOUR_ID
MacOS
~/Library/Application\ Support/config.json
(It should appear after you launched DCL launcher once)open Decentraland.app --args --launcher_anonymous_id YOUR_ID
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.