politeiavoter: Update prompt pass placement. #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff moves the dcrwallet password prompt to the begining of the voting function so that the user does not have to wait for the expensive O(n) wallet calls to complete in order to input their password. It also adds in a dcrwallet call that verifies the password is correct. This patch was submitted by moo31337.
marcopeereboom
approved these changes
Aug 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff moves the dcrwallet password prompt to the begining of the
voting function so that the user does not have to wait for the expensive
O(n) wallet calls to complete in order to input their password. It also
adds in a dcrwallet call that verifies the password is correct.
This patch was submitted by marcopeereboom.