Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(kernelcpd): add early check on segmentation parameters #128

Merged
merged 9 commits into from
Mar 6, 2021

Conversation

oboulant
Copy link
Collaborator

@oboulant oboulant commented Mar 2, 2021

closes #123

@github-actions github-actions bot added the Type: Fix Bug or Bug fixes label Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #128 (afa2709) into master (743eb5d) will increase coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   95.12%   96.01%   +0.88%     
==========================================
  Files          41       40       -1     
  Lines         965      979      +14     
==========================================
+ Hits          918      940      +22     
+ Misses         47       39       -8     
Impacted Files Coverage Δ
src/ruptures/utils/utils.py 80.95% <ø> (ø)
src/ruptures/costs/costrank.py 93.33% <100.00%> (+0.22%) ⬆️
src/ruptures/detection/binseg.py 100.00% <100.00%> (ø)
src/ruptures/detection/bottomup.py 100.00% <100.00%> (ø)
src/ruptures/detection/dynp.py 100.00% <100.00%> (ø)
src/ruptures/detection/kernelcpd.py 100.00% <100.00%> (ø)
src/ruptures/detection/pelt.py 100.00% <100.00%> (ø)
src/ruptures/detection/window.py 100.00% <100.00%> (ø)
src/ruptures/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743eb5d...afa2709. Read the comment docs.

@oboulant oboulant requested a review from deepcharles March 2, 2021 10:47
@oboulant oboulant merged commit 91513fc into master Mar 6, 2021
@oboulant oboulant deleted the test-minsize branch May 3, 2021 08:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Fix Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation error on KernelCPD with larger min_size than data
2 participants