-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[api] Added Early stopping configuration (#38) #2806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this @jagodevreede! I'm sure many training users will appreciate it. Your PR looks pretty good, but I left a few comments.
I'll also run the CI. It will probably complain from our code formatter and checkstyle. See http://docs.djl.ai/docs/development/development_guideline.html#coding-conventions for some explanations and how to check it locally as well
...tion/src/main/java/ai/djl/integration/tests/training/listener/EarlyStoppingListenerTest.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/training/listener/EarlyStoppingListener.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/training/listener/EarlyStoppingListener.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/training/listener/EarlyStoppingListener.java
Outdated
Show resolved
Hide resolved
Local build is happy now, let's see if CI agrees with that. Also fixed your comments. |
…make the test run on JDK11 in gradle.
I was able to reproduce the failing ci build locally with JDK11. Fixed it in commit 402df41 |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2806 +/- ##
============================================
- Coverage 72.08% 72.04% -0.05%
- Complexity 5126 7106 +1980
============================================
Files 473 703 +230
Lines 21970 31751 +9781
Branches 2351 3294 +943
============================================
+ Hits 15838 22875 +7037
- Misses 4925 7303 +2378
- Partials 1207 1573 +366
☔ View full report in Codecov by Sentry. |
Description
This PR implements a listener for early stopping as described in #38. And takes the code @gforman44 and implements that in a
TrainingListener
resolves #38