Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backslashes in custom commands not escaped in JSON #955

Closed
Zguy opened this issue Aug 31, 2023 · 2 comments
Closed

Backslashes in custom commands not escaped in JSON #955

Zguy opened this issue Aug 31, 2023 · 2 comments
Assignees
Labels
🪳 Bug Something isn't working
Milestone

Comments

@Zguy
Copy link

Zguy commented Aug 31, 2023

I have a project with a custom command that contains backslashes.
When I save the project, the command is saved unescaped in the JSON file

"customCommands": [{ "command": "out\build\x64-Debug\bin\App.exe", "when": "Manual" }],

This is not valid JSON.

When I try to open the project, I get the following error

Cannot read properties of null (reading 'externalLevels') (TypeError)

Which is an incredibly misleading error. externalLevels is nowhere close to customCommands physically within the JSON file.

If I manually escape the backslashes in the custom command with a text editor I can open the project again, but every time I save it's saved unescaped again.

@deepnight deepnight self-assigned this Aug 31, 2023
@deepnight deepnight added the 🪳 Bug Something isn't working label Aug 31, 2023
@deepnight deepnight added this to the 1.3.5 milestone Aug 31, 2023
@deepnight
Copy link
Owner

Thanks for reporting this bug!

@deepnight
Copy link
Owner

Fixed in 1.4

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🪳 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants