Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add missing headers for new toolchain #41

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Mar 2, 2025

These are necessary for compiling with Ubuntu 24.04 default toolchain/boost.

Greate job! I've tried to run this on Ubuntu 24.04, facing a lot of issues. I eventually failed because I cannot install the RDMA driver. But I don't want to waste my work. So here is part of my modifications to make it compile.

See also

With these change, plus some changes to third_party, I'm able to build this on Ubuntu 24.04, with -Werror removed and google/leveldb#1255, ClickHouse/clickhouse-cpp#296, facebook/rocksdb#11118

These are necessary for compiling with Ubuntu 24.04 default toolchain/boost.
Copy link
Collaborator

@SF-Zhou SF-Zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@SF-Zhou SF-Zhou merged commit 309a258 into deepseek-ai:main Mar 2, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants