-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix check params #3036
fix check params #3036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this was accidentally added. Thank you @satpalsr
Removing this |
@satpalsr Looks like this check was removed in GH-2083 and was likely done due to certain models having mixed dtypes for various parameters. I think this likely warrants a deeper discussion about what purpose In the meantime, I think we can close this PR since simply removing the
|
Check params was removed for Bloom.
Not evident why.