reduce cpu host overhead when using moe #5578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohtana
reviewed
May 31, 2024
tohtana
reviewed
May 31, 2024
There was a problem hiding this comment.
@ranzhejiang Thank you for your contribution! I have a few questions about your changes. Can you clarify them?
ranzhejiang
force-pushed
the
zhejiang/reduce_host_overhead_moe
branch
from
e9e32f4 to
d860d2c
Compare
|
Hi, @tohtana I have clarified the modifications you mentioned and retest this PR with Megatron-Deepspeed on GPU platform(8xA800). It runs well and loss remains consistent with the original method, Could you please help review it again? Thanks! |
ranzhejiang
force-pushed
the
zhejiang/reduce_host_overhead_moe
branch
from
686f511 to
23ec4a1
Compare
ranzhejiang
force-pushed
the
zhejiang/reduce_host_overhead_moe
branch
from
23ec4a1 to
1cb0efd
Compare
|
#5881 also adopts this plan to reduce cpu time |
tohtana
approved these changes
Aug 21, 2024
23 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation
.to('cpu')is not necessary for exp_counts, and it will cause device to host synchronization which damage performance.