Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cli tests to cover custom image and image in npx pepr build #1370

Closed
cmwylie19 opened this issue Oct 31, 2024 · 0 comments · Fixed by #1401
Closed

cli tests to cover custom image and image in npx pepr build #1370

cmwylie19 opened this issue Oct 31, 2024 · 0 comments · Fixed by #1401
Assignees
@cmwylie19
Labels
enhancement New feature or request
Milestone
v0.40.0

Comments

@cmwylie19
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We need to protect our cli commands, we currently do not have a mechanism for testing these and they require manual testing.

Describe the solution you'd like

  • Given a new PR and CI job
  • When CI runs, it tests custom image and image
  • Then we know the functionality is not broken
@cmwylie19 cmwylie19 added the enhancement New feature or request label Oct 31, 2024
@cmwylie19 cmwylie19 self-assigned this Nov 6, 2024
@cmwylie19 cmwylie19 added this to the v0.40.0 milestone Nov 6, 2024
@cmwylie19 cmwylie19 mentioned this issue Nov 7, 2024
Merged
5 tasks
cmwylie19 added a commit that referenced this issue Nov 7, 2024
@cmwylie19
chore: pepr build custom image (#1401)
29d1c8f 
## Description

Builds a Pepr module and read manifests from known locations to assert
that the custom image was used.

CI test for `npx pepr build --custom-image'

End to End Test:  <!-- if applicable -->  
(See [Pepr Excellent
Examples](https://github.com/defenseunicorns/pepr-excellent-examples))

## Related Issue

Fixes #1370 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@cmwylie19 cmwylie19

Labels
enhancement New feature or request
Projects
Pepr Project Board
Status: ✅ Done
Milestone
v0.40.0
Development

Successfully merging a pull request may close this issue.

chore: pepr build custom image defenseunicorns/pepr
1 participant
@cmwylie19