feat: adds very basic feature flag capabilities #1058
+84
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
force-pushed
the
embed-tofu-binary
branch
from
8a22f25 to
ad7bee7
Compare
YrrepNoj
requested changes
Jan 21, 2025
| if !featureflags.IsEnabled("tofu") { | ||
| fmt.Println("The 'plan' command is not enabled. Use the '--feature=tofu' flag or set the FEATURE_FLAG environment variable.") | ||
| return nil | ||
| } | ||
| return useEmbeddedTofu() | ||
| }, | ||
| DisableFlagParsing: true, |
There was a problem hiding this comment.
As you pointed out last week, flagParsing is currently disabled and will need to be handled in some way.
Context: I originally disabled flagParsing so that we can pass all the tofu flags directly as args. If flagParsing is not disabled we will have to manually capture all the flags the user is trying to provide to tofu and forward them along.
chore: touch the src/cmd/bin/tofu file so it exists for tests, schema, and doc validation chore: small hack to appease the linter for embeded files chore: remove unnecessary todo comment initial spike of feature flags Signed-off-by: catsby <clint@defenseunicorns.com> fix license Signed-off-by: catsby <clint@defenseunicorns.com> add feature flag gate to apply/plan stubs Signed-off-by: catsby <clint@defenseunicorns.com>
Signed-off-by: catsby <clint@defenseunicorns.com>
Signed-off-by: catsby <clint@defenseunicorns.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds very basic
--feature=<thing>feature flag support. NOTE: when integrating this I found the--featureflag support is at odds with theDisableFlagParsing.Note: this PR is opened against the
embed-tofu-binarybranch.Calling
planwithout featuretofuenabled:With feature
tofuenabled:Type of change
Checklist before merging