Skip to content

Commit

Permalink
chore!: update custom properties key (#253)
Browse files Browse the repository at this point in the history
## Description

- Updating all instances of custom: [] to additionalNetworkAllow: []

> [!CAUTION]
> **BREAKING CHANGE** `custom` has changed to `additionalNetworkAllow`

## Related Issue

Fixes #
<!-- or -->
Relates to #

https://github.com/orgs/defenseunicorns/projects/118/views/12?pane=issue&itemId=87152090&issue=defenseunicorns%7Cuds-package-maintenance%7C5
## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Release-As: v17.6.1-uds.2
  • Loading branch information
codyshoffner and Racer159 authored Dec 10, 2024
1 parent 55b37cb commit de49d8c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion bundle/uds-bundle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ packages:
valkey:
uds-valkey-config:
values:
- path: custom
- path: additionalNetworkAllow
value:
- direction: Ingress
selector:
Expand Down
2 changes: 1 addition & 1 deletion charts/config/templates/uds-package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ spec:
{{- end }}

# Custom rules for unanticipated scenarios
{{- range .Values.custom }}
{{- range .Values.additionalNetworkAllow }}
- direction: {{ .direction }}
selector:
{{ .selector | toYaml | nindent 10 }}
Expand Down
2 changes: 1 addition & 1 deletion charts/config/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ mirroring:
gitalyCgroupsInit:
enabled: false

# custom:
# additionalNetworkAllow:
# # Notice no `remoteGenerated` field here on custom internal rule
# - direction: Ingress
# selector:
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Network policies are controlled via the `uds-gitlab-config` chart in accordance
- `redis`: sets network policies for accessing a Redis-compatible server from all GitLab services (`webservice`, `toolbox`, `sidekiq`, `migrations`, `gitlab-exporter`)
- `postgres`: sets network policies for accessing a Postgres database from all GitLab services (`webservice`, `toolbox`, `sidekiq`, `migrations`, `gitlab-exporter`)
- `mirroring`: sets network policies that allow the gitlab repository mirroring feature to work. It defaults to only `https` (443) but can be set to allow the other protocols gitlab supports via the `ports` key.
- `custom`: sets custom network policies for the GitLab namespace - this allows for custom integrations with other services (i.e. Jira)
- `additionalNetworkAllow`: sets custom network policies for the GitLab namespace - this allows for custom integrations with other services (i.e. Jira)

> [!NOTE]
> Currently the GitLab UDS Package contains Istio `PeerAuthentication` exceptions to allow the `dependency` init containers to reach out and check the Redis and Postgres services. These are only added with `redis.internal` or `postgres.internal` set to `true` and will be removed once UDS Core [switches to native sidecars](https://github.com/defenseunicorns/uds-core/issues/536).
Expand Down

0 comments on commit de49d8c

Please # to comment.