Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove lua version table #508

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Remove lua version table #508

merged 2 commits into from
Jan 22, 2025

Conversation

menaechmi
Copy link
Contributor

LuaJIT having moved to a rolling release makes the table kind of unhelpful - there's no real information that the version can give the reader and it's technically outdated. I think saying "Defold uses a custom fork" gets the information across in a better way and replaces 2/3s of the table.

So I separated the important information that iOS and Nintendo Switch don't allow JIT compilation, while HTML5 uses a different Lua. It's below the important, because it explains the presence of the banner AND the reader's eye will be naturally drawn towards the banner and following clause.

@britzl
Copy link
Contributor

britzl commented Jan 21, 2025

I think saying "Defold uses a custom fork" gets the information across in a better way and replaces 2/3s of the table.

I do not agree. We are not using a custom fork of LuaJIT, but a specific commit from the rolling releases. Which version/commit is defined in our build script: https://github.com/defold/defold/blob/dev/share/ext/luajit/version.sh

Copy link
Contributor Author

@menaechmi menaechmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote that after reading this PR linked from the Release Notes: defold/defold#9244 and https://github.com/defold/LuaJIT but looking into it, I agree "custom fork" implies more changes.

How about this instead:

Due to LuaJIT's rolling release model, each Defold build uses a different version. To find the exact version of LuaJit, see the LuaJIT build script and select the appropriate tag for the Defold release.

And then "We aim to keep Defold the same across all platforms..." followed by the important for a more consistent flow.

docs/en/manuals/lua.md Outdated Show resolved Hide resolved
docs/en/manuals/lua.md Show resolved Hide resolved
docs/en/manuals/lua.md Outdated Show resolved Hide resolved
Co-authored-by: menaechmi <menaechmi@protonmail.com>
@britzl
Copy link
Contributor

britzl commented Jan 22, 2025

Thanks!

@britzl britzl merged commit 5cef4c5 into defold:master Jan 22, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants