Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removing dependency on reagent #25

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Conversation

shen-tian
Copy link
Contributor

Fixes #24

As it stands now, reagent 0.8 and, thus, React 16 is pulled in. re-frame 10.x still depends on reagent 0.7/React 15.

Technically, this might break a project that was relying on reagent 0.8 features. This primarily involves:

  • Fragments: [:<>] tags
  • Class names as collections: [:div {:class ["header" "header-large"]}]
  • Error boundaries. Form-3 components with the :component-did-catch method

But they can then just add the explicit dependency for reagent 0.8.1 to get status quo back.

@shen-tian
Copy link
Contributor Author

@deg : the main changes are on the view side of things, so doesn't affect this lib. And I had a look through the firestore example, and nothing there stands out.

@deg deg merged commit 216595b into deg:master Sep 13, 2018
@deg
Copy link
Owner

deg commented Sep 13, 2018

Sorry for my delay. Got lost in my inbox.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants