-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: spin build failed #109
fix: spin build failed #109
Conversation
Thanks for your contribution! This does resolve the problem that #108 brings. However, I'd love to propose an alternative way - instead of adding another target at the This allows us to reuse the same step in both the CI and local dev environment. |
Makefile
Outdated
@@ -55,7 +55,7 @@ build-wws-cross-%: install-cross | |||
|
|||
.PHONY: build-spin | |||
build-spin: | |||
cargo build --release --manifest-path=containerd-shim-spin-v1/Cargo.toml | |||
rustup target add wasm32-unknown-unknown && cargo build --release --manifest-path=containerd-shim-spin-v1/Cargo.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to add new step called install-rust-targets
that adds both wasm32-unknown-unknown and wasm32-wasi targets, and make it a prerequisite for build-spin
and build-slight
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your advice. I modified a few places:
- Makefile added install-rust-targets
- build.yaml and ci.yaml use install-rust-targets
- There seems to be an issue with names being overridden in the Makefile
.PHONY: build-slight
build-slight:
.PHONY: build-wws
build-slight:
@microsoft-github-policy-service agree |
5ca7a1e
to
d045c1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@dierbei could you please sign your commits? |
d045c1c
to
99f7db0
Compare
99f7db0
to
b6cb79b
Compare
@Mossaka I tried doing a rebase so maybe the commit will be clearer. |
Fix #108