Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump the Spin Version #114

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Bump the Spin Version #114

merged 2 commits into from
Jul 15, 2023

Conversation

stevesloka
Copy link
Contributor

Bumps the spin version to v1.4.0.

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! you beat me to it.

It's so awesome to see a version bump only needs to change the version tag!

@Mossaka
Copy link
Member

Mossaka commented Jul 14, 2023

I believe you will need to bump wasmtime to 10

@Mossaka
Copy link
Member

Mossaka commented Jul 14, 2023

Could you please sign the CLA? @stevesloka

@stevesloka
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Outerbase"

@stevesloka
Copy link
Contributor Author

@Mossaka I has to force push to rebase and sign the commit. I also commented on the CLA, so hopefully that all works. 🤞

@Mossaka
Copy link
Member

Mossaka commented Jul 15, 2023

Thank you! Once CI passes I will merge it in.

@Mossaka
Copy link
Member

Mossaka commented Jul 15, 2023

Oh it looks like the commits are not signed yet. @stevesloka

@stevesloka stevesloka force-pushed the bumpSpinVersion branch 4 times, most recently from 14851a9 to 9745f3a Compare July 15, 2023 02:05
stevesloka and others added 2 commits July 14, 2023 22:08
Signed-off-by: Steve Sloka <steve@outerbase.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
@stevesloka
Copy link
Contributor Author

@Mossaka ok sorry about that, I got all the signing fixed up now. Thanks!

@Mossaka Mossaka merged commit 3e09e37 into deislabs:main Jul 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants