refactor: runtime takes no dependencies on capabilities #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
…me crate Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Mossaka
force-pushed
the
jiazho/refactor-runtime
branch
from
8e9cdac to
0add22a
Compare
Mossaka
changed the title
|
@Mossaka: I'd like to know what the perf difference is at startup. When you say there's a tradeoff, I wanna know what it is.... |
devigned
requested changes
Nov 14, 2022
I believe the tradeoff is not runtime impacting, but rather code design impacting. It makes the CLI need to know a bit more about the capabilities. I believe this is a preferable tradeoff when weighed against the runtime needing to know details about the capabilities. |
|
OK, perfect. I saw the internal chatting after commenting. Sounds great to me! |
danbugs
reviewed
Nov 14, 2022
danbugs
requested changes
Nov 14, 2022
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
danbugs
approved these changes
Nov 17, 2022
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
devigned
approved these changes
Nov 18, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to admit that this is a relative large PR and apologize beforehand. It refactors the core of slight - the runtime crate to not depend directly on any of the slight capabilities, including slight-kv, slight-mq, etc. This comes at a cost though. The slight CLI implementation now needs to know how to constrct a capability service before adding it to the slight runtime builder, which is a acceptable compromise.
In addition to the runtime refactoring, this PR also cleans up some redudent code in slight capabilities. Particularly, this PR removed capability-state.
Signed-off-by: Jiaxiao Zhou jiazho@microsoft.com