Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improved error messages when failing to provide a correct slightfile #273

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

danbugs
Copy link
Collaborator

@danbugs danbugs commented Dec 14, 2022

This closes #161

When the provided file doesn't exist, we now get:
image

When the provided file isn't a correct slightfile, we now get:
image

Signed-off-by: danbugs danilochiarlone@gmail.com

Signed-off-by: danbugs <danilochiarlone@gmail.com>
@danbugs danbugs added the 💫 refactor Improvement or change upon an already existing feature label Dec 14, 2022
@danbugs danbugs added this to the End of Year Milestone milestone Dec 14, 2022
@danbugs danbugs requested a review from Mossaka December 14, 2022 05:57
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danbugs danbugs merged commit 35cb5a2 into deislabs:main Dec 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
💫 refactor Improvement or change upon an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slight panics when the config path isn't a slightfile.
2 participants