Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated wit-bindgen to fermyon/wit-bindgen-backport and wasmtime to 5 #344

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Mar 3, 2023

This PR uses wit-bindgen-backport to replace the mainline wit-bindgen in order to unblock slight to update to the newest wasmtime. Currently wit-bindgen-backport uses wasmtime 5.0.0 which is a version older than the latest wasmtime. I opened a PR to bump version up in their repo. As soon as that one merges, I will update slight to wasmtime 6.0.0 and continue to do this for every major release of wasmtime.

The end goal is switch back to the mainline wit-bindgen as soon as we support wasm component and the newest WIT syntax. This work is out of scope for this PR.

….0.0

Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
@Mossaka Mossaka marked this pull request as draft March 3, 2023 22:20
@Mossaka Mossaka marked this pull request as ready for review March 4, 2023 00:24
Copy link
Collaborator

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mossaka Mossaka merged commit c9d6fee into main Mar 4, 2023
@Mossaka Mossaka deleted the wit-bindgen-port branch March 4, 2023 01:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants