Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove js-delegatable-utils dependency on eth-simple-keyring #14

Open
danfinlay opened this issue Dec 14, 2022 · 0 comments
Open

Remove js-delegatable-utils dependency on eth-simple-keyring #14

danfinlay opened this issue Dec 14, 2022 · 0 comments

Comments

@danfinlay
Copy link
Collaborator

eth-simple-keyring depends on ethereumjs-wallet, which depends on the browserify polyfill for crypto, which means none of these modules work in an environment that doesn't polyfill the crypto module. That includes the latest create-react-app, or any lean webpack configuration. Removing that dependency will allow this module to live in leaner and more modern projects.

danfinlay added a commit to delegatable/mobymask-ui that referenced this issue Dec 14, 2022
This is sad and shouldn't be necessary. delegatable/delegatable-eth#14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant