Replace [ expr ] with [[ expr ]] and (( expr ))
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllKind
changed the title
[ expr ]' with [[ expr ]]' and (( expr ))[ expr ] with [[ expr ]] and (( expr ))
In regard of: dell#268. Replaced all instances of `[ expr ]' I could find with `[[ expr ]]', or `(( expr ))'. Also removed the now obsolete quoting. Some unnecessary grouped conditional commands have been consolidated. Signed-off-by: Mart Frauenlob <AllKind@fastest.cc>
AllKind
force-pushed
the
conditional_cmd
branch
from
de4bb73 to
4709361
Compare
evelikov
reviewed
Jan 9, 2024
| @@ -334,20 +334,20 @@ do_depmod() | |||
| return | |||
| fi | |||
| # $1 = kernel version | |||
| if [ "${current_os}" != "Linux" ] ; then | |||
| if [[ ${current_os} != Linux ]] ; then | |||
There was a problem hiding this comment.
Since you're changing these, can you please drop the curly brackets as well?
Thanks o/
There was a problem hiding this comment.
Comment applies for the whole patch.
Cases like substring and array handling (further down) obviously need to retain the curly brackets to work.
|
As this is inconsistent across the whole program, I'd prefer to do that in a separate PR. |
|
Indeed, things are a bit messy atm. Fixing it in as follow-up PR is fine. Thanks for this, merging |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regard of: #268.
Replaced all instances of
[ expr ]I could find with[[ expr ]], or(( expr )).Also removed the now obsolete quoting.
Some unnecessary grouped conditional commands have been consolidated.