Import zsh-completion and polish a bit #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on commit: a9386df5581487e5e34ecb3ce422bacf62d10c3d [Emil Velikov] - rename the file and wire to install/uninstall Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
A bunch of the options got removed a few releases back - drop them. While here apply minor polish - reorder couple of options and update few comments [Emil Velikov] - split/squash as applicable, commit message Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reorder some of the options to be somewhat consistent relative to the dkms script and zsh completion. [Emil Velikov] - split/squash as applicable, commit message Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work of @hyperupcall over all #391 with a few fixes applied.
Since a few PRs landed, I thought about addressing the review comments myself, although since I cannot push to the initial (user?) repo here's a separate PR.
This way we can run it through the CI before merging.