Ported turf measurement center function #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@dellisd can you move https://github.com/dellisd/spatial-k/projects/1#card-37013816 in progress please. Thank you. |
Closed
dellisd
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Sorry for the delay in reviewing. This is great, thank you!
My only request is that you add another overload of the function to accept a Geometry object, similar to how the other functions have multiple overloads to accept the different types of geometry/features.
fun center(geometry: Geometry): PointThanks again!
P72B
force-pushed
the
feature/issue4_measurement_center
branch
from
8339af2
to
cecc420
Compare
|
Hi, I provided the overload function to provide also the center from a plain geometry. Thank you for the hint and this nice lib! |
|
Hi @dellisd any updates here about the pending merge? |
|
Really sorry for the delay again! This is great, thank you so much |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue#4 fix suggestion
I ported the JS turf center function into
Measurement.ktclass and added a simple testVisually I confirmed the output here. Testfile GeoJson is on gist.
