Skip to content

REML lists in main display omit text after embedded UL or OL #82

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
delphidabbler opened this issue Dec 21, 2022 · 2 comments
Closed

REML lists in main display omit text after embedded UL or OL #82

delphidabbler opened this issue Dec 21, 2022 · 2 comments
Assignees
@delphidabbler
Labels
bug Bug report completed Work has been completed on this issue and changes have been committed to `develop` branch..

Comments

@delphidabbler
Copy link
Owner

If a list is embedded within a list, and text in the outer list item follows the end of the embedded list then that text is not displayed in the main display, unless it is itself a block, such as a paragraph.

For example:

<ol>
  <li>
    Foo
    <ul>
      <li>
        Bar
      </li>
    </ul>
    Baz
  </li>
</ol>

will display Foo but not Baz, but

<ol>
  <li>
    Foo
    <ul>
      <li>
        Bar
      </li>
    </ul>
    <p>
      Baz
    </p>
  </li>
</ol>

will display both Foo and Baz.
@delphidabbler delphidabbler self-assigned this Dec 21, 2022
@delphidabbler delphidabbler added accepted Accepted for implementation / fixing bug Bug report labels Dec 21, 2022
@delphidabbler delphidabbler added the started Work has started on this issue. label Dec 21, 2022
@delphidabbler
Copy link
Owner Author

delphidabbler commented Dec 21, 2022 •
edited
Loading

Working on fixing at same time, and in same feature branch, as issue #81.

@delphidabbler delphidabbler mentioned this issue Dec 21, 2022
Closed
@delphidabbler delphidabbler added completed Work has been completed on this issue and changes have been committed to `develop` branch.. and removed accepted Accepted for implementation / fixing labels Dec 21, 2022
@delphidabbler delphidabbler added started Work has started on this issue. accepted Accepted for implementation / fixing and removed started Work has started on this issue. completed Work has been completed on this issue and changes have been committed to `develop` branch.. labels Dec 21, 2022
@delphidabbler delphidabbler changed the title REML Lists in main display omit text after embedded UL or OL REML lists in main display omit text after embedded UL or OL Dec 23, 2022
delphidabbler added a commit that referenced this issue Apr 8, 2023
@delphidabbler
Missing text at end of detail pane list items fixed
36bc983 
Code added to track and detect if text is being written inside a list
item and to output any inline text as HTML between the end of a nested
list and the end of a list item.

Such detection is then used in logic that determines when to output such
orphaned text.

Fixes #82
delphidabbler added a commit that referenced this issue Apr 8, 2023
@delphidabbler
Merge branch 'feature/81+82-reml-lists-not-rendered-in-plain-text-or-…
d9da938 
…rtf' into develop

Resolved conflicts:
*	Src/ActiveText.UHTMLRenderer.pas
*	Src/ActiveText.UMain.pas
*	Src/ActiveText.UTextRenderer.pas
*	Src/USourceGen.pas
*	Src/UTextSnippetDoc.pas

All resolved in favour of the incoming changes from the feature branch.

Fixes #81. Fixes #82.
@delphidabbler delphidabbler added completed Work has been completed on this issue and changes have been committed to `develop` branch.. and removed accepted Accepted for implementation / fixing started Work has started on this issue. labels Apr 8, 2023
@delphidabbler
Copy link
Owner Author

Fixed at merge commit d9da938

@delphidabbler delphidabbler mentioned this issue Apr 8, 2023
Closed
@delphidabbler delphidabbler removed this from the Confirmed for next patch milestone Apr 9, 2023
@delphidabbler delphidabbler moved this to Done - Awaiting Release in CodeSnip May 23, 2023
@delphidabbler delphidabbler moved this from Done - Awaiting Release to Done - released in CodeSnip May 23, 2023
@delphidabbler delphidabbler removed this from CodeSnip Jun 18, 2023
delphidabbler added a commit that referenced this issue Jul 13, 2023
@delphidabbler
Missing text at end of detail pane list items fixed
044e44c 
Code added to track and detect if text is being written inside a list
item and to output any inline text as HTML between the end of a nested
list and the end of a list item.

Such detection is then used in logic that determines when to output such
orphaned text.

Fixes #82
delphidabbler added a commit that referenced this issue Jul 13, 2023
@delphidabbler
Missing text at end of detail pane list items fixed
41844a6 
Code added to track and detect if text is being written inside a list
item and to output any inline text as HTML between the end of a nested
list and the end of a list item.

Such detection is then used in logic that determines when to output such
orphaned text.

Fixes #82
delphidabbler added a commit that referenced this issue Jul 13, 2023
@delphidabbler
Merge branch 'feature/81+82-reml-lists-not-rendered-in-plain-text-or-…
c7a6444 
…rtf' into develop

Resolved conflicts:
*	Src/ActiveText.UHTMLRenderer.pas
*	Src/ActiveText.UMain.pas
*	Src/ActiveText.UTextRenderer.pas
*	Src/USourceGen.pas
*	Src/UTextSnippetDoc.pas

All resolved in favour of the incoming changes from the feature branch.

Fixes #81. Fixes #82.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@delphidabbler delphidabbler

Labels
bug Bug report completed Work has been completed on this issue and changes have been committed to `develop` branch..
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delphidabbler