Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Kernel] Minor test clean up #2184

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[Kernel] Minor test clean up #2184

merged 1 commit into from
Oct 13, 2023

Conversation

vkorukanti
Copy link
Collaborator

@vkorukanti vkorukanti commented Oct 13, 2023 •
edited
Loading

Description

Remove the golden table dv-with-columnmapping from the kernel module and add it the golden-tables module (generated using GoldenTables.scala. This was done originally because of #1886 which was fixed in the current master.

How was this patch tested?

Ran the DeletionVectorSuite and it passes.

allisonport-db
allisonport-db reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@allisonport-db allisonport-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkorukanti vkorukanti merged commit c793297 into delta-io:master Oct 13, 2023
@vkorukanti vkorukanti deleted the enableCMTests branch May 9, 2024 02:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@allisonport-db allisonport-db allisonport-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkorukanti @allisonport-db