-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Spark] Support in-place migration from unpartitioned table to clustered table #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zedtang
changed the title
Support in-place migration from unpartitioned table to clustered table.
[Spark] Support in-place migration from unpartitioned table to clustered table
May 29, 2024
dabao521
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! Left a few comments, and let's add add more validations in the test.
spark/src/test/scala/org/apache/spark/sql/delta/clustering/ClusteringTableFeatureSuite.scala
Outdated
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/clustering/ClusteringTableFeatureSuite.scala
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/clustering/ClusteringTableFeatureSuite.scala
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/clustering/ClusteringTableFeatureSuite.scala
Show resolved
Hide resolved
dabao521
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
spark/src/test/scala/org/apache/spark/sql/delta/clustering/ClusteringTableFeatureSuite.scala
Outdated
Show resolved
Hide resolved
richardc-db
pushed a commit
to richardc-db/delta
that referenced
this pull request
Jun 5, 2024
…red table (delta-io#3174) ## Description Support in-place migration from unpartitioned table to clustered table. If the table is an unpartitioned table and users run `ALTER TABLE CLUSTER BY` on it, it will now create a clustered table with ClusteringMetadataDomain. Resolves delta-io#2460 ## How was this patch tested? New UTs.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Support in-place migration from unpartitioned table to clustered table. If the table is an unpartitioned table and users run
ALTER TABLE CLUSTER BY
on it, it will now create a clustered table with ClusteringMetadataDomain.Resolves #2460
How was this patch tested?
New UTs.
Does this PR introduce any user-facing changes?
No