[Kernel] Change Class.forName() usage in the LogStoreProvider.
#3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
approved these changes
Jun 24, 2024
vkorukanti
changed the title
Class.forName() usage in the LogStoreProvider.Class.forName() usage in the LogStoreProvider.
3 tasks
vkorukanti
pushed a commit
to vkorukanti/delta
that referenced
this pull request
Aug 30, 2024
…`. (delta-io#3304) Look for the `LogStore` class more broadly in the class loader than just the thread local's class loader. The thread context class loader requires the Thread local variables to have the `LogStore` in it, but this class loader may not have all the dependencies wired up. Not tested yet. Fixes delta-io#3299.
abhishekrb19
added a commit
to abhishekrb19/incubator-druid
that referenced
this pull request
Sep 27, 2024
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Look for the
LogStoreclass more broadly in the class loader than just the thread local's class loader. The thread context class loader requires the Thread local variables to have theLogStorein it, but this class loader may not have all the dependencies wired up.How was this patch tested?
Not tested yet.
Fixes #3299.